Test: 2 miners with one attempting forks #5034
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jferrant
approved these changes
Aug 1, 2024
github-merge-queue bot
pushed a commit
that referenced
this pull request
Aug 1, 2024
Test: 2 miners with one attempting forks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a new integration test for behavior when 2 miners are running, and one of the miners engages in forking behavior. The test asserts that the signer set prevents them from producing the fork.
This PR also cleans up some the other signer set forking test some: instead of running for 20 tenures, it runs until both miners have produced 3 tenures.